Add separate parameters for HtmlRenderer settings
#137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vjik
commented
Jan 17, 2025
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #137 +/- ##
============================================
+ Coverage 77.08% 77.81% +0.73%
Complexity 184 184
============================================
Files 14 14
Lines 576 586 +10
============================================
+ Hits 444 456 +12
+ Misses 132 130 -2 ☔ View full report in Codecov by Sentry. |
xepozz
requested changes
Jan 17, 2025
Member
xepozz
left a comment
xepozz
left a comment
There was a problem hiding this comment.
what's the reason for such changes? will array $settings be deprecated for further versions?
Member
Author
Typed properties is better than array. Array is incosistent to other Yii3 code. |
samdark
approved these changes
Jan 17, 2025
xepozz
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.